Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

APP-304 Update flag for App definition in app build help #725

Merged

Conversation

aiordache
Copy link
Contributor

@aiordache aiordache commented Nov 4, 2019

- What I did

Updated build flag for App description

- How to verify it

$ docker app build --help
Usage:	docker app build [OPTIONS] BUILD_PATH
Build an App image from an App definition (.dockerapp)
Options:
    ...
  -f, --file string             App definition as a .dockerapp directory
    ...

- A picture of a cute animal (not mandatory)

Signed-off-by: Anca Iordache anca.iordache@docker.com

@carolinebriaud
Copy link
Contributor

You should not change the description part ("App definition as a .dockerapp directory" was OK), only the flag name. The ticket in JIRA wasn't up-to-date. I'll modify it right now to reflect that.
Could you please revert the change in the description? thanks

Signed-off-by: Anca Iordache <anca.iordache@docker.com>
@aiordache aiordache force-pushed the app-304_correct_app_build_help branch from 0fa5f8d to af9fafd Compare November 4, 2019 16:14
Copy link
Contributor

@carolinebriaud carolinebriaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit 38bedc0 into docker:master Nov 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants