Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

--installer-context option is experimental #733

Merged
merged 1 commit into from Nov 12, 2019

Conversation

ndeloof
Copy link
Contributor

@ndeloof ndeloof commented Nov 8, 2019

- What I did
Made installer-context option experimental

- How I did it
Annotate as experimental:true

- How to verify it
if experimental is disabled, option is not available

- Description for the changelog
installer-context option is experimental

- A picture of a cute animal (not mandatory)

image

@ndeloof ndeloof changed the title --installer-context option is experimental [WiP] --installer-context option is experimental Nov 8, 2019
@ndeloof ndeloof changed the title [WiP] --installer-context option is experimental --installer-context option is experimental Nov 12, 2019
Signed-off-by: Nicolas De Loof <nicolas.deloof@gmail.com>
@codecov
Copy link

codecov bot commented Nov 12, 2019

Codecov Report

Merging #733 into master will decrease coverage by 0.66%.
The diff coverage is 28.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #733      +/-   ##
==========================================
- Coverage   69.72%   69.05%   -0.67%     
==========================================
  Files          64       63       -1     
  Lines        3495     3400      -95     
==========================================
- Hits         2437     2348      -89     
- Misses        738      741       +3     
+ Partials      320      311       -9
Impacted Files Coverage Δ
internal/commands/validate.go 75% <100%> (ø) ⬆️
internal/cliopts/installerContext.go 27.58% <100%> (+2.58%) ⬆️
internal/commands/root.go 63.95% <16.66%> (-10.75%) ⬇️
internal/commands/image/list.go 83.67% <0%> (-4%) ⬇️
internal/packager/custom.go
internal/packager/cnab.go 97.94% <0%> (+0.27%) ⬆️
types/parameters/parameters.go 93.65% <0%> (+1.58%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeb12c0...9c97d5b. Read the comment docs.

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit 04214e3 into docker:master Nov 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants