This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Fix remove image by Id #740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jean-Christophe Sirot <jean-christophe.sirot@docker.com>
rumpl
reviewed
Nov 13, 2019
ndeloof
approved these changes
Nov 13, 2019
jcsirot
force-pushed
the
fix-remove-by-id
branch
from
1768d47
to
e82ec43
Compare
Codecov Report
@@ Coverage Diff @@
## master #740 +/- ##
=====================================
Coverage 70% 70%
=====================================
Files 64 64
Lines 3600 3600
=====================================
Hits 2520 2520
Misses 757 757
Partials 323 323Continue to review full report at Codecov.
|
rumpl
approved these changes
Nov 13, 2019
Signed-off-by: Jean-Christophe Sirot <jean-christophe.sirot@docker.com>
jcsirot
force-pushed
the
fix-remove-by-id
branch
from
e82ec43
to
26cc7d3
Compare
rumpl
reviewed
Nov 14, 2019
| if len(b.refsMap[id]) == 0 { | ||
| return fmt.Errorf("no such image %q", reference.FamiliarString(ref)) | ||
| } else if len(b.refsMap[id]) > 1 { | ||
| return fmt.Errorf("unable to delete %q - App is referenced in multiple repositories", reference.FamiliarString(ref)) |
There was a problem hiding this comment.
Should we tell the user which repositories?
There was a problem hiding this comment.
the docker image rm command does not do it
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Fix the
docker app image rm <id>command with the following behavior- A picture of a cute animal (not mandatory)
