This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Fix examples #746
Merged
Fix examples #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sign your commits following these rules: $ git clone -b "fix-examples" git@github.com:carolinebriaud/app.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354324912
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
carolinebriaud
force-pushed
the
fix-examples
branch
2 times, most recently
from
fbf013d
to
e4ae881
Compare
carolinebriaud
force-pushed
the
fix-examples
branch
2 times, most recently
from
f91da70
to
cc2825e
Compare
carolinebriaud
force-pushed
the
fix-examples
branch
from
cc2825e
to
950cbbe
Compare
Codecov Report
@@ Coverage Diff @@
## master #746 +/- ##
=======================================
Coverage 68.98% 68.98%
=======================================
Files 63 63
Lines 3440 3440
=======================================
Hits 2373 2373
Misses 749 749
Partials 318 318Continue to review full report at Codecov.
|
carolinebriaud
force-pushed
the
fix-examples
branch
from
950cbbe
to
bd242c4
Compare
Fix hello-world example. Remove cnab-helm example. Signed-off-by: Caroline Briaud <caroline.briaud@docker.com>
carolinebriaud
force-pushed
the
fix-examples
branch
from
bd242c4
to
24944b1
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Update README for docker/app/examples.
Fix hello-world example.
Remove cnab-helm example.
- How to verify it
Read the files
- A picture of a cute animal (not mandatory)
