Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test before pushing your image (docs) #455

Merged
merged 1 commit into from Sep 1, 2021
Merged

Test before pushing your image (docs) #455

merged 1 commit into from Sep 1, 2021

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Sep 1, 2021

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@francisdb
Copy link

@francisdb francisdb commented Sep 1, 2021

So this should work with the currently released versions?

@crazy-max
Copy link
Member Author

@crazy-max crazy-max commented Sep 1, 2021

So this should work with the currently released versions?

Yes

@felipecrs
Copy link

@felipecrs felipecrs commented Sep 1, 2021

Thanks @crazy-max for documenting this. I was doing the same thing here; the approach is reasonable.

@crazy-max
Copy link
Member Author

@crazy-max crazy-max commented Sep 1, 2021

@felipecrs Thanks for your feedback!

@crazy-max crazy-max merged commit d0931a7 into docker:master Sep 1, 2021
23 checks passed
@crazy-max crazy-max deleted the doc branch Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants