Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add cgroup-parent, shm-size, ulimit inputs #501

Merged
merged 2 commits into from Nov 17, 2021
Merged

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Nov 16, 2021

available since buildx 0.7.0.

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max force-pushed the new-inputs branch 2 times, most recently from 3eb0059 to 064c20d Compare Nov 16, 2021
@crazy-max crazy-max requested a review from tonistiigi Nov 16, 2021
@crazy-max crazy-max marked this pull request as ready for review Nov 16, 2021
Copy link
Member

@tonistiigi tonistiigi left a comment

I don't think it makes sense to add quiet this way. It's only for backward compact anyway.

Note that these also depend on buildkit version.

@crazy-max
Copy link
Member Author

@crazy-max crazy-max commented Nov 16, 2021

I don't think it makes sense to add quiet this way. It's only for backward compact anyway.

Yes I hesitated to add it because it also brings nothing to the action as such. I will remove it.

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max changed the title add cgroup-parent, quiet, shm-size, ulimit inputs add cgroup-parent, shm-size, ulimit inputs Nov 16, 2021
@crazy-max crazy-max requested a review from tonistiigi Nov 16, 2021
@crazy-max crazy-max merged commit 9ed5823 into docker:master Nov 17, 2021
26 checks passed
@crazy-max crazy-max deleted the new-inputs branch Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants