Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add imageid output and use metadata to set digest output #569

Merged
merged 1 commit into from Mar 14, 2022

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Mar 6, 2022

fixes #461

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

Copy link
Member

@tonistiigi tonistiigi left a comment

If this still needs some work maybe separate out the digest part. Only the digest from metadata is needed for the new buildx. Getting image ID output is a new feature and not time critical.

@crazy-max
Copy link
Member Author

@crazy-max crazy-max commented Mar 9, 2022

@tonistiigi As docker/buildx#980 and docker/buildx#989 are now merged I think we can move forward with this PR and keep imageID output. WDYT?

@crazy-max crazy-max marked this pull request as ready for review Mar 9, 2022
@crazy-max crazy-max marked this pull request as draft Mar 9, 2022
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@crazy-max crazy-max force-pushed the imageid-digest branch 4 times, most recently from bc058cb to 83a1b4f Compare Mar 14, 2022
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max marked this pull request as ready for review Mar 14, 2022
@crazy-max crazy-max requested a review from tonistiigi Mar 14, 2022
if (digest) {
await core.group(`Digest`, async () => {
core.info(digest);
context.setOutput('digest', digest);
Copy link
Member

@tonistiigi tonistiigi Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a fallback for imageID here if metadata is undefined? I guess this was already in many releases so maybe not that important.

Copy link
Member Author

@crazy-max crazy-max Mar 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

metadata-file flag is available since buildx 0.6.0-rc1 so I guess it's fine: docker/buildx#605

Copy link

@t-botz t-botz Mar 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit broke our pipeline. In our instance, for some reasons, image id is defined and digest isn't.

Fix is easy, but I wish you had bumped the major version of the plugin as it breaks backward compatibility :)

Copy link
Member Author

@crazy-max crazy-max Mar 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@t-botz What's version of buildx? Do you have a link to your repo?

@crazy-max crazy-max requested a review from tonistiigi Mar 14, 2022
@crazy-max crazy-max merged commit e115266 into docker:master Mar 14, 2022
31 checks passed
@crazy-max crazy-max deleted the imageid-digest branch Mar 14, 2022
jglick added a commit to jglick/starter-workflows that referenced this issue Apr 18, 2022
jglick added a commit to cloudbees-oss/inject-metadata-velero-plugin that referenced this issue Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants