Skip to content

Commit

Permalink
docker-container: allow setting custom buildkit image
Browse files Browse the repository at this point in the history
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
  • Loading branch information
tonistiigi committed Aug 1, 2019
1 parent bcc882c commit afd8210
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 5 deletions.
13 changes: 9 additions & 4 deletions driver/docker-container/driver.go
Expand Up @@ -22,12 +22,13 @@ import (
"github.com/pkg/errors"
)

var buildkitImage = "moby/buildkit:master" // TODO: make this verified and configuratble
var defaultBuildkitImage = "moby/buildkit:buildx-stable-1" // TODO: make this verified

type Driver struct {
driver.InitConfig
factory driver.Factory
netMode string
image string
}

func (d *Driver) Bootstrap(ctx context.Context, l progress.Logger) error {
Expand All @@ -52,8 +53,12 @@ func (d *Driver) Bootstrap(ctx context.Context, l progress.Logger) error {
}

func (d *Driver) create(ctx context.Context, l progress.SubLogger) error {
if err := l.Wrap("pulling image "+buildkitImage, func() error {
rc, err := d.DockerAPI.ImageCreate(ctx, buildkitImage, types.ImageCreateOptions{})
imageName := defaultBuildkitImage
if d.image != "" {
imageName = d.image
}
if err := l.Wrap("pulling image "+imageName, func() error {
rc, err := d.DockerAPI.ImageCreate(ctx, imageName, types.ImageCreateOptions{})
if err != nil {
return err
}
Expand All @@ -64,7 +69,7 @@ func (d *Driver) create(ctx context.Context, l progress.SubLogger) error {
}

cfg := &container.Config{
Image: buildkitImage,
Image: imageName,
}
if d.InitConfig.BuildkitFlags != nil {
cfg.Cmd = d.InitConfig.BuildkitFlags
Expand Down
4 changes: 3 additions & 1 deletion driver/docker-container/factory.go
Expand Up @@ -45,8 +45,10 @@ func (f *factory) New(ctx context.Context, cfg driver.InitConfig) (driver.Driver
if v == "host" {
d.InitConfig.BuildkitFlags = append(d.InitConfig.BuildkitFlags, "--allow-insecure-entitlement=network.host")
}
case "image":
d.image = v
default:
return nil, errors.Errorf("invalid driver option %s for docker-container driver")
return nil, errors.Errorf("invalid driver option %s for docker-container driver", k)
}
}

Expand Down

0 comments on commit afd8210

Please sign in to comment.