Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: return imageID when loading without docker driver #980

Merged
merged 1 commit into from Mar 4, 2022

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Mar 1, 2022

Copy link
Member

@tonistiigi tonistiigi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should just use containerimage.config.digest always and if it is not set (eg. multi-platform) then the full digest as before.

No need to do anything special for --load as multi-platform don't load anyway.

Also need to make sure this doesn't break the github action and update if it may.

@tonistiigi tonistiigi added this to the v0.8.0 milestone Mar 4, 2022
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max
Copy link
Member Author

Also need to make sure this doesn't break the github action and update if it may.

It's fine for the GitHub Action with this behavior but as discussed we might create a new output named imageid that will contain the actual imageid and set digest output accordingly.

@tonistiigi
Copy link
Member

It's fine for the GitHub Action with this behavior but as discussed we might create a new output named imageid that will contain the actual imageid and set digest output accordingly.

But what field does the action use atm? If it uses iidfile then it needs to be updated before the release.

@crazy-max
Copy link
Member Author

Hum yeah atm digest output returns content of iidfile, so need to make changes for the action. Will do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--iidfile contains mismatching id
2 participants