Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove yamllint #1182

Merged
merged 1 commit into from
Jun 23, 2022
Merged

chore: remove yamllint #1182

merged 1 commit into from
Jun 23, 2022

Conversation

crazy-max
Copy link
Member

yamllint was added in #451 to validate our workflows but now GitHub reports YAML syntax issues so let's just remove it.

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max requested a review from thaJeztah June 23, 2022 09:19
@thaJeztah
Copy link
Member

Does it also report issues with other yaml files? (I see a golang-ci and codecov YAML, so wondering if any of those could potentially have issues that would now be missed)

@crazy-max
Copy link
Member Author

This will be reported by the tool itself like:

#13 ERROR: process "/bin/sh -c golangci-lint run" did not complete successfully: exit code: 3
------
 > [stage-0 5/5] RUN --mount=target=/go/src/github.com/docker/buildx --mount=target=/root/.cache,type=cache   golangci-lint run:
#13 0.530 level=error msg="Can't read config: can't read viper config: While parsing config: yaml: line 12: could not find expected ':'"

@thaJeztah
Copy link
Member

Yeah; was wondering if yamllint would provide a more useful / friendly error (and I think it also verifies for "well-formed" / consistent formatting).

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazy-max crazy-max merged commit f8884a5 into docker:master Jun 23, 2022
@crazy-max crazy-max deleted the remove-yamllint branch June 23, 2022 11:26
@tonistiigi
Copy link
Member

I think yamlint handles more than just parse errors but also normalizes formatting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants