k8s: generate node name if not provided #1673
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up docker/setup-buildx-action#215
Appending nodes to a kubernetes builder currently fails if node name is not set because it would be a duplicated endpoint:
This change will generate a random node name if not defined for the kubernetes driver:
@dvdksn Might need docs changes at https://docs.docker.com/build/drivers/kubernetes/#native to remove the need of setting
--node
(maybe we could just explain setting the node name is optional).