Log error from WithError if found #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
⬆️ Follow-up to #924.
Should help to provide more details for moby/buildkit#3027.
Previously, we would discard the error field provided, which provides valuable contextual information. This patch will include the error field if it is provided. A quick glance through our usage of
WithErrorindicates that the errors shown should look mostly reasonable (e.g. we won't display duplicated info).We still don't want to just print out all the available spans, since that will include the
spanIDandtraceIDfrom BuildKit, but this singular field is a well-known key, so we should include it whenever present.