Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: prefer local image resolution for docker driver #1886

Merged
merged 1 commit into from Jun 21, 2023
Merged

build: prefer local image resolution for docker driver #1886

merged 1 commit into from Jun 21, 2023

Conversation

crazy-max
Copy link
Member

If pull option is not set we should prefer local image resolution for docker driver. In follow-up we should look at making the --pull flag accepting a specific state like the docker run command does: https://docs.docker.com/engine/reference/commandline/run/#pull

@crazy-max crazy-max marked this pull request as ready for review June 15, 2023 16:15
tianon
tianon approved these changes Jun 15, 2023
View reviewed changes
Copy link
Contributor

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

tianon
tianon reviewed Jun 15, 2023
View reviewed changes
tests/build.go Show resolved Hide resolved
@thaJeztah
Copy link
Member

In follow-up we should look at making the --pull flag accepting a specific state like the docker run command does: https://docs.docker.com/engine/reference/commandline/run/#pull

@crazy-max crazy-max force-pushed the docker-local branch 2 times, most recently from 967e46c to 4a43f33 Compare June 19, 2023 09:59
crazy-max
crazy-max commented Jun 19, 2023
View reviewed changes
tests/build.go Outdated Show resolved Hide resolved
jedevc
jedevc reviewed Jun 20, 2023
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
jedevc
jedevc reviewed Jun 20, 2023
View reviewed changes
Dockerfile Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@crazy-max crazy-max mentioned this pull request Jun 20, 2023
Merged
jedevc
jedevc reviewed Jun 21, 2023
View reviewed changes
tests/build.go Outdated Show resolved Hide resolved
@crazy-max
build: prefer local image resolution for docker driver
c2500ea 
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@crazy-max crazy-max merged commit bd672ea into docker:master Jun 21, 2023
59 checks passed
@crazy-max crazy-max deleted the docker-local branch June 21, 2023 09:20
@tianon tianon mentioned this pull request Aug 1, 2023
Merged
@tianon tianon mentioned this pull request Aug 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jedevc jedevc jedevc approved these changes

@tonistiigi tonistiigi Awaiting requested review from tonistiigi

@tianon tianon Awaiting requested review from tianon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@crazy-max @thaJeztah @tianon @tonistiigi @jedevc