debug: Following-up patches for error messages #2086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
tonistiigi
reviewed
Oct 20, 2023
monitor/monitor.go
Outdated
| @@ -233,6 +239,14 @@ type monitor struct { | |||
| invokeIO *ioset.Forwarder | |||
| invokeCancel func() | |||
| attachedPid atomic.Value | |||
|
|
|||
| lastBuildResult *LastBuildResult | |||
There was a problem hiding this comment.
variable name lastBuildResult is ok but the type returned from RunMonitor should be different. Maybe MonitorBuildResult?
There was a problem hiding this comment.
Fixed the type name to MonitorBuildResult.
Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
This can catch and print more errors on monitor side not only process-related errors. Signed-off-by: Kohei Tokunaga <ktokunaga.mail@gmail.com>
ktock
force-pushed
the
debug-errormessage
branch
from
057a647
to
14834e6
Compare
tonistiigi
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
buildx debugcommand #2006 (review)buildx debugcommand #2006 (review)