metrics: send metrics to the otel collector endpoint when active #2155
Conversation
jsternberg
force-pushed
the
otel-exporter
branch
from
07b5add
to
6a4d2c1
Compare
jsternberg
changed the title
jsternberg
force-pushed
the
otel-exporter
branch
2 times, most recently
from
3d2c722
to
c1a1d48
Compare
There was a problem hiding this comment.
Please add docs for how to collect/view the data and something that lists all the metrics that buildx will export.
If this docker.cli.count is something that currently serves more like a test value and may change in the future where more collection points are added then it should be behind BUILDX_ opt-in env var until it is considered stable.
go.mod
Outdated
| @@ -51,6 +51,12 @@ require ( | |||
| k8s.io/client-go v0.26.7 | |||
| ) | |||
|
|
|||
| require ( | |||
There was a problem hiding this comment.
This new block in here probably isn't necessary.
There was a problem hiding this comment.
Let me fix this.
|
@tonistiigi at the current moment, the metrics can't be exported or seen through a user-defined means. I'll add some docs for the metrics to get that started as I think we should allow a way to expose the metrics to end-users, but CLI metrics are a bit different from service metrics that they're generally more ephemeral. I can add it behind an environment variable, but in its current iteration, these metrics can only be consumed by our backend without recompiling the source. I don't know if that changes the requirement to add an experimental flag for this. My fear here is that this data is already going to a backend that also has an experimental flag and we'll be adding too many experimental flags and won't get any data. But yes. This metric is primarily meant to be a test one so I can see the metrics are working and to avoid Go telling me that the value isn't used. |
jsternberg
force-pushed
the
otel-exporter
branch
3 times, most recently
from
99c3d25
to
98197e8
Compare
| @@ -926,3 +940,29 @@ func maybeJSONArray(v string) []string { | |||
| } | |||
| return []string{v} | |||
| } | |||
|
|
|||
| func recordVersionInfo(mp metric.MeterProvider, command string) { | |||
| if !isExperimental() { | |||
There was a problem hiding this comment.
nit: add extra comment in here saying that we are still in the process of testing/stabilizing these counters.
jsternberg
force-pushed
the
otel-exporter
branch
4 times, most recently
from
77e8c35
to
d2f0a45
Compare
|
End to end tests are functional now. I've split the vendor update into the PR here so that will have to merge first. The issue seemed to stem from how unix sockets are handled in the OTEL library. The I was also accidentally passing an empty endpoint entirely because the |
Introduce a meter provider to the buildx cli that will send metrics to the otel-collector included in docker desktop if enabled. This will send usage metrics to the desktop application but also send metrics to a user-provided otlp receiver endpoint through the standard environment variables. This introduces a single metric which is the cli count for build and bake along with the command name and a few additional attributes. Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
jsternberg
force-pushed
the
otel-exporter
branch
from
d2f0a45
to
7094eb8
Compare
Introduce a meter provider to the buildx cli that will send metrics to
the otel-collector included in docker desktop if enabled.
This will send usage metrics to the desktop application but also send
metrics to a user-provided otlp receiver endpoint through the standard
environment variables.
This introduces a single metric which is the cli count for build and
bake along with the command name and a few additional attributes.