Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: avoid warn on empty config value #390

Merged
merged 1 commit into from Nov 3, 2020

Conversation

tonistiigi
Copy link
Member

@crazy-max

Signed-off-by: Tonis Tiigi tonistiigi@gmail.com

@crazy-max
Copy link
Member

@tonistiigi Maybe better to use os.LookupEnv?

Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
@tonistiigi
Copy link
Member Author

@crazy-max updated

Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tonistiigi tonistiigi merged commit 778fbb4 into docker:master Nov 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants