Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bake docs #700

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Update bake docs #700

merged 1 commit into from
Aug 3, 2021

Conversation

crazy-max
Copy link
Member

Follow-up #532 #538 #539 #541 #575 #671

Signed-off-by: CrazyMax crazy-max@users.noreply.github.com

@crazy-max crazy-max marked this pull request as ready for review July 28, 2021 09:22
docs/reference/buildx_bake.md Outdated Show resolved Hide resolved
docs/reference/buildx_bake.md Outdated Show resolved Hide resolved
@crazy-max
Copy link
Member Author

PTAL @thaJeztah

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall looks great. I left a suggestion for a follow-up (likely), one minor nit, and a comment about the git:// scheme (could be a bug, not sure)

docs/reference/buildx_bake.md Show resolved Hide resolved
docs/reference/buildx_bake.md Outdated Show resolved Hide resolved
docs/reference/buildx_bake.md Show resolved Hide resolved
docs/reference/buildx_bake.md Show resolved Hide resolved
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@crazy-max crazy-max merged commit cd133ce into docker:master Aug 3, 2021
@crazy-max crazy-max deleted the bake-docs branch August 3, 2021 12:53
@crazy-max crazy-max added kind/docs and removed docs labels Sep 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants