build: add cgroup-parent support #814
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
crazy-max
commented
Oct 27, 2021
crazy-max
commented
Oct 27, 2021
build/build.go
Outdated
| FrontendAttrs: map[string]string{}, | ||
| Frontend: "dockerfile.v0", | ||
| FrontendAttrs: map[string]string{ | ||
| "cgroup-parent": opt.CgroupParent, |
There was a problem hiding this comment.
wonder if we should not check if cgroup-parent is already specified for a driver and in this case warn the user about it?
There was a problem hiding this comment.
I don't think they are strictly related.
There was a problem hiding this comment.
we should not set it if empty as there is no nil value
There was a problem hiding this comment.
ah yes indeed will fix that
crazy-max
force-pushed
the
cgroup-parent
branch
from
e1113fe
to
8c8334c
Compare
crazy-max
force-pushed
the
cgroup-parent
branch
from
7caf4a6
to
4fa4284
Compare
Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
cgroup-parent
branch
from
4fa4284
to
dd15969
Compare
tonistiigi
approved these changes
Oct 28, 2021
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
follow-up #810 (comment)