Add an flag to buildx rm to keep the buildkitd daemon running #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
reviewed
Nov 19, 2021
commands/rm.go
Outdated
| @@ -70,23 +71,28 @@ func rmCmd(dockerCli command.Cli, rootOpts *rootOptions) *cobra.Command { | |||
|
|
|||
| flags := cmd.Flags() | |||
| flags.BoolVar(&options.keepState, "keep-state", false, "Keep BuildKit state") | |||
| flags.BoolVar(&options.keepBuildkitd, "keep-buildkitd", false, "Keep the buildkitd daemon running") | |||
There was a problem hiding this comment.
I think --keep-instance would be a better name.
There was a problem hiding this comment.
@crazy-max maybe --keep-daemon? "Instance" is not very descriptive either as anything can have "an instance".
There was a problem hiding this comment.
--keep-daemon sgtm too 👍
I'll make the change
crazy-max
requested changes
Nov 20, 2021
docs/reference/buildx_rm.md
Outdated
| @@ -34,7 +34,7 @@ Same as [`buildx --builder`](buildx.md#builder). | |||
| Keep BuildKit state, so it can be reused by a new builder with the same name. | |||
| Currently, only supported by the [`docker-container` driver](buildx_create.md#driver). | |||
|
|
|||
| ### <a name="keep-buildkitd"></a> Keep the buildkitd daemon running (--keep-buildkitd) | |||
| ### <a name="keep-daemon"></a> Keep the buildkitd daemon running (--keep-daemon) | |||
|
|
|||
| Keep the buildkitd daemon running after the buildx context is removed. This is useful is when you manage buildkitd daemons and buildx contexts independently. | |||
There was a problem hiding this comment.
This is useful is when > This is useful when
crazy-max
requested changes
Nov 22, 2021
There was a problem hiding this comment.
Please also squash the commits. https://github.com/docker/buildx/blob/master/.github/CONTRIBUTING.md#review
Add --keep-daemon to the `rm` command option to preserve the buildkitd daemon after the buildx context is deleted. Signed-off-by: Mayeul Blanzat <mayeul.blanzat@datadoghq.com>
zaymat
force-pushed
the
mayeul/docker-buildx-rm--keep-buildkitd
branch
from
8866bb2
to
72dab55
Compare
Sure 👍 Just did it |
tonistiigi
approved these changes
Nov 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the flag
--keep-buildkitdto thebuildx rmcommand to preserve the buildkitd daemon after the buildx context is deleted.This flag can be useful when someone uses the
kubernetesdriver and manages thebuildkitdeployment outside ofbuildx.docker buildx rm --help Usage: docker buildx rm [NAME] Remove a builder instance Options: --builder string Override the configured builder instance --keep-buildkitd Keep the buildkitd daemon running --keep-state Keep BuildKit stateFixes #794
Signed-off-by: Mayeul Blanzat mayeul.blanzat@datadoghq.com