bake: additional support for named context on remote inputs #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
tonistiigi
commented
Feb 24, 2022
tonistiigi
commented
- Update named context paths to be relative of remote inputs
- Add basic validation that named paths don't escape the current working directory when loaded from remote sources.
tonistiigi
commented
Feb 24, 2022
| if inp == nil || inp.State == nil { | ||
| return nil | ||
| } | ||
| if v, ok := os.LookupEnv("BAKE_ALLOW_REMOTE_FS_ACCESS"); ok { |
There was a problem hiding this comment.
@crazy-max I think in our github actions we can define this by default as the whole system is in a vm anyway.
There was a problem hiding this comment.
On GHA they could include /home/runner/.docker which contains auth token in config.json if login step has been done in a previous step.
tonistiigi
force-pushed
the
bake-context-validation
branch
from
ea42084
to
dee1d82
Compare
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
This is a stopgap before proper entitlements support is implemented. Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
bake-context-validation
branch
from
dee1d82
to
91e550b
Compare
crazy-max
reviewed
Feb 25, 2022
There was a problem hiding this comment.
Can you add BAKE_ALLOW_REMOTE_FS_ACCESS to the list of built-in variables: https://github.com/docker/buildx/blob/master/docs/reference/buildx_bake.md#built-in-variables
I don't really want to make this very official. Hopefully, it would be removed in the next release if we have proper entitlements support. |
crazy-max
approved these changes
Feb 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.