Merge pull request #270 from tych0/warn-only-about-password-on-cli

login: print a big warning when using --password
docker · Jul 8, 2017 · c99530b · c99530b
2 parents 534c3d2 + c269ad2
commit c99530b
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/cli/command/registry/login.go b/cli/command/registry/login.go
@@ -47,6 +47,10 @@ func runLogin(dockerCli command.Cli, opts loginOptions) error {
 	ctx := context.Background()
 	clnt := dockerCli.Client()
 
+	if opts.password != "" {
+		fmt.Fprintln(dockerCli.Err(), "WARNING! Using --password via the CLI is insecure.")
+	}
+
 	var (
 		serverAddress string
 		authServer    = command.ElectAuthServer(ctx, dockerCli)