Compiling error: http: invalid Host header

[ElectricPulse]

Description

I am trying to build docker-cli from source for my freebsd 13.2 host system, because currently my whole docker toolchain over at freebsd is a mess. I am aware that I can compile docker-cli without docker, but didn't yet bother to try it so the following is an attempt at bootstrapping it from Virtual Box with an arch linux VM. On the VM I installed docker, the docker-cli, docker-buildx (AUR). Upon launching docker buildx bake I get the following log:
build.txt
any further docker buildx bake results in just the error: http: invalid Host header being printed. Restarting the system clears the whole cache (which docker buildx prune apparently doesn't do) and the build command again returns the full log like the one attached.

PS. How should I link the binary so that it works with bsd's own libc implementation?

Reproduce

docker buildx bake

Expected behavior

No response

docker version

Client:
 Version:           24.0.2
 API version:       1.43
 Go version:        go1.20.4
 Git commit:        cb74dfcd85
 Built:             Mon May 29 15:50:06 2023
 OS/Arch:           linux/amd64
 Context:           default

Server:
 Engine:
  Version:          24.0.2
  API version:      1.43 (minimum version 1.12)
  Go version:       go1.20.4
  Git commit:       659604f9ee
  Built:            Mon May 29 15:50:06 2023
  OS/Arch:          linux/amd64
  Experimental:     false
 containerd:
  Version:          v1.7.2
  GitCommit:        0cae528dd6cb557f7201036e9f43420650207b58.m
 runc:
  Version:          1.1.7
  GitCommit:        
 docker-init:
  Version:          0.19.0
  GitCommit:        de40ad0

docker info

Client:
 Version:    24.0.2
 Context:    default
 Debug Mode: false
 Plugins:
  buildx: Docker Buildx (Docker Inc.)
    Version:  0.11.0
    Path:     /usr/lib/docker/cli-plugins/docker-buildx

Server:
 Containers: 1
  Running: 0
  Paused: 0
  Stopped: 1
 Images: 1
 Server Version: 24.0.2
 Storage Driver: overlay2
  Backing Filesystem: extfs
  Supports d_type: true
  Using metacopy: true
  Native Overlay Diff: false
  userxattr: false
 Logging Driver: json-file
 Cgroup Driver: systemd
 Cgroup Version: 2
 Plugins:
  Volume: local
  Network: bridge host ipvlan macvlan null overlay
  Log: awslogs fluentd gcplogs gelf journald json-file local logentries splunk syslog
 Swarm: inactive
 Runtimes: io.containerd.runc.v2 runc
 Default Runtime: runc
 Init Binary: docker-init
 containerd version: 0cae528dd6cb557f7201036e9f43420650207b58.m
 runc version: 
 init version: de40ad0
 Security Options:
  seccomp
   Profile: builtin
  cgroupns
 Kernel Version: 6.4.3-arch1-1
 Operating System: Arch Linux
 OSType: linux
 Architecture: x86_64
 CPUs: 1
 Total Memory: 6.13GiB
 Name: somehostname
 ID: d5fd4a52-a5ba-401b-aaa2-0cf7f8edcf26
 Docker Root Dir: /var/lib/docker
 Debug Mode: false
 Experimental: false
 Insecure Registries:
  127.0.0.0/8
 Live Restore Enabled: false

Additional Info

The guest VM is connected to the internet via a bridge adapter

[nicks]

You're probably hitting moby/moby#45935

[thaJeztah]

Thanks for reporting!

Yup, this was a breaking change in Go1.20.6 / 1.19.11 (https://go.dev/issue/60374);

• Golang client fails to attach to streams with "http: invalid Host header" with go1.20.6, go1.19.11 moby/moby#45935

Which was fixed by moby/moby#45942, and backported to all release-branches, but not yet released.

Let me close this one in the meantime, but feel free to continue the conversation.

[ElectricPulse]

Excuse my ignorance but to make sure:
It's a problem with the docker-engine I currently have installed, I should downgrade to a working version or compile it from scratch and then proceed to recompile docker-cli?

[thaJeztah]

If you want to build the tagged release (24.0.4), then you must compile it with go1.20.5, which is the version of go that was used for that release;

cli/Dockerfile

Line 4 in 3713ee1

ARG GO_VERSION=1.20.5

Or you can build from the "tip" of the 24.0 release branches, which already have the fix for this.

[thaJeztah]

And if the issue is with a package that was provided by the Arch Linux packagers, then it's worth opening a ticket with them (we don't provide packages for arch linux on our download.docker.com package repositories).

[ElectricPulse]

If you want to build the tagged release (24.0.4), then you must compile it with go1.20.5, which is the version of go that was used for that release;

cli/Dockerfile

Line 4 in 3713ee1

ARG GO_VERSION=1.20.5

Or you can build from the "tip" of the 24.0 release branches, which already have the fix for this.

I still don't get it :(.

1. By "compile" you mean using the go compiler directly without running docker buildx?

(docker buildx bake for me fails for all the branches above the 19.* release with the same "Host..." error.)

2. If I am indeed suppose to use the go compiler directly where is the guide/build steps for that?

3. To reiterate my previous post: I thought the command docker buildx might be failing because of the docker engine/client I currently have installed: is that the case?

[thaJeztah]

Ah, sorry, think I missunderstood you; I thought you meant "I compiled a binary, and when using the binary, I got that error".

Yes, if you get this error when using docker buildx bake, then it looks like your version of Docker (and Buildx) are broken. If those are packages you installed from Arch Linux's package repository, it means that they have built broken packages (recompiled with a Go version that's not compatible). If possible, you can temporarily downgrade to an earlier version of their packages.

Fixes for Buildx have also been merged and backported, but are not yet in a tagged release (docker/buildx#1952), so until that's the case, compiling buildx with go1.20.6 will produce a non-functional binary.

[thaJeztah]

docker 24.0.5 was tagged and released, which contains the compatibility fix for go1.20.6. I expect packages to be updated in the Arch Linux package repositories.

[felipelalli]

NixOS should the same update.

[nix-shell:~/wa/docker]$ sudo docker exec -it container zsh
http: invalid Host header

[nix-shell:~/wa/docker]$ docker --version
Docker version 20.10.25, build v20.10.25

Related: Docker fails to run containers #244159

[thaJeztah]

• related ticket in the Golang issue tracker; net/http: go 1.20.6 host validation breaks setting Host to a unix socket address golang/go#61431

[dhawansolanki]

Try : "DOCKER_BUILDKIT=0" before running your existing command.
For Eg : sudo DOCKER_BUILDKIT=0 docker-compose up --build -d

[thaJeztah]

@dhawansolanki this ticket is about building the source in this repository, which requires BuildKit. Also this bug has been fixed in current versions of docker, so should no longer occur.