Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add exec option to tmpfs mounts #1083

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

adshmh
Copy link
Contributor

@adshmh adshmh commented May 25, 2018

Added exec option to tmpfs mounts, part of work on docker PR for tmpfs exec option

Signed-off-by: Arash Deshmeh adeshmeh@ca.ibm.com

- What I did
Added ability to pass exec/noexec option to tmpfs mounts

- How I did it
Added required fields in the types, options, and the corresponding conversion functions.

- How to verify it
I have added unit tests to verify the conversion

- Description for the changelog
exec option can be passed to tmpfs mounts

- A picture of a cute animal (not mandatory but encouraged)

@adshmh adshmh requested a review from vdemeester as a code owner May 25, 2018 15:14
…eplaced by vendoring moby/moby

Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
…ersion to Tmpfs RawOptions

Signed-off-by: Arash Deshmeh <adeshmeh@ca.ibm.com>
@adshmh adshmh force-pushed the add-exec-option-to-tmpfs-mounts branch from 491f1a9 to cd0b270 Compare May 25, 2018 15:17
@adshmh
Copy link
Contributor Author

adshmh commented May 25, 2018

Docs need to be updated as well to reflect the new option. I will update the PR once the selected field names are approved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants