[RFD] Revert "Match Swarm in how to combine filters" #1085
+8
−6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When filtering objects on labels, and two different filter values
are passed for a single label, Swarm combines those filters as
an AND. Effectively, this means that:
Means;
This is never true, because labels are stored as a "map" (so an
object can only have a single label named "something". As
a result this filter will never return a result.
This behavior is also inconsistent with other situations, where
filters are combined using an OR, for example;
Means;
This commit was added to make Kubernetes mimic the (odd) behavior,
so that the behavior would be consistent for both orchestrators.
Given that the existing (swarm/docker) behavior;
It may be a better option to fix the situation in the Swarm side
(if desirable, keep the old behavior based on API version), and
revert this commit to not let this behavior find its way into
new features.
This reverts commit 297866e (#1023).