Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a doc.go file so the compose/schema/data directory can be vendore… #1169

Merged
merged 1 commit into from
Jul 2, 2018

Conversation

silvin-lubecki
Copy link
Contributor

- What I did
Compose JSON schemas are stored in directory, without any go code in it, so it cannot be vendored if the pruning is enabled.

- How I did it
I simply added a doc.go file...

- How to verify it

  1. Vendor docker/cli in another project
  2. Add somewhere in your project:
import _ github.com/docker/cli/cli/compose/schema/data
  1. Prune the vendoring
    => Schemas are still there!

- A picture of a cute animal (not mandatory but encouraged)
image

…d in another project, without being pruned.

Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
@silvin-lubecki
Copy link
Contributor Author

Cloned from #1162 which I couldn't reopen. Finally @thaJeztah, I really want/need the json files 😅

@thaJeztah
Copy link
Member

deja vu

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🌮

@vdemeester vdemeester merged commit 981c099 into docker:master Jul 2, 2018
@GordonTheTurtle GordonTheTurtle added this to the 18.07.0 milestone Jul 2, 2018
@silvin-lubecki silvin-lubecki deleted the schema-vendoring branch July 2, 2018 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants