Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add omitempty on compose config top-level types #1170

Merged
merged 1 commit into from Jul 2, 2018

Conversation

vdemeester
Copy link
Collaborator

Signed-off-by: Vincent Demeester vincent@sbr.pm

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Vincent Demeester <vincent@sbr.pm>
@vdemeester
Copy link
Collaborator Author

@silvin-lubecki 😽 💓

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LFTM

@silvin-lubecki silvin-lubecki merged commit 18091ea into docker:master Jul 2, 2018
@GordonTheTurtle GordonTheTurtle added this to the 18.07.0 milestone Jul 2, 2018
@silvin-lubecki silvin-lubecki deleted the omit-silvin branch July 2, 2018 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants