Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.09] build: add options to builder prune #1334

Merged
merged 2 commits into from Sep 5, 2018

Conversation

Projects
None yet
6 participants
@tiborvass
Copy link
Contributor

tiborvass commented Sep 4, 2018

Cherry-pick of #1327

Depends on docker/engine#42

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Sep 4, 2018

Codecov Report

Merging #1334 into 18.09 will decrease coverage by 0.17%.
The diff coverage is 17.39%.

@@            Coverage Diff            @@
##            18.09   #1334      +/-   ##
=========================================
- Coverage   54.78%   54.6%   -0.18%     
=========================================
  Files         293     294       +1     
  Lines       19324   19417      +93     
=========================================
+ Hits        10586   10602      +16     
- Misses       8074    8149      +75     
- Partials      664     666       +2

@tiborvass tiborvass force-pushed the tiborvass:18.09-cmd-builder-prune-with-options branch 5 times, most recently from 45532f9 to 1cd1d86 Sep 5, 2018

tiborvass added some commits Aug 30, 2018

build: add options to builder prune
This patch adds --filter, --keep-storage, --all and --force to builder prune.

Signed-off-by: Tibor Vass <tibor@docker.com>
(cherry picked from commit c806eb4)
Signed-off-by: Tibor Vass <tibor@docker.com>
system df: show table output for build cache
Signed-off-by: Tibor Vass <tibor@docker.com>
(cherry picked from commit ca608c2)
Signed-off-by: Tibor Vass <tibor@docker.com>

@tiborvass tiborvass force-pushed the tiborvass:18.09-cmd-builder-prune-with-options branch from 1cd1d86 to 3c37d6a Sep 5, 2018

@andrewhsu
Copy link
Contributor

andrewhsu left a comment

SGTM

@tiborvass tiborvass merged commit d8aefad into docker:18.09 Sep 5, 2018

8 of 9 checks passed

codecov/patch 17.39% of diff hit (target 50%)
Details
ci/circleci: cross Your tests passed on CircleCI!
Details
ci/circleci: lint Your tests passed on CircleCI!
Details
ci/circleci: shellcheck Your tests passed on CircleCI!
Details
ci/circleci: test Your tests passed on CircleCI!
Details
ci/circleci: validate Your tests passed on CircleCI!
Details
codecov/project 54.6% (-0.18%) compared to a818677
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
dco-signed All commits are signed

@thaJeztah thaJeztah added this to the 18.09.0 milestone Sep 11, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.