Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the sparse "docker port" output + doc, what maps to what #1420

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thomas-k-git
Copy link

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "patch-1" git@github.com:thomas-klambauer/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@thomas-k-git
Copy link
Author

See https://docs.docker.com/engine/reference/commandline/port/#examples
Most people rate this doc page badly.(192 negative, 70 positive), assuming the same reason why I was annoyed, no explanation in what direction the mapping happens (contains first, host first?!)

@codecov-io
Copy link

Codecov Report

Merging #1420 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1420   +/-   ##
=======================================
  Coverage   54.26%   54.26%           
=======================================
  Files         289      289           
  Lines       19331    19331           
=======================================
  Hits        10490    10490           
  Misses       8165     8165           
  Partials      676      676

Signed-off-by: Thomas.Klambauer <Thomas.Klambauer@dynatrace.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants