moby/moby#37961 : cp command can copy multiple files #1495
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sign your commits following these rules: $ git clone -b "implements-moby-feature-request-#37961" git@github.com:fossilmfc/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
… does fixed broken tests Signed-off-by: Filip Ilavský <fossilmfc@gmail.com>
… does fixed broken tests Signed-off-by: Filip Ilavský <fossilmfc@gmail.com>
…ub.com/fossilmfc/cli into implements-moby-feature-request-#37961 # Conflicts: # cli/command/container/cp.go
Codecov Report
@@ Coverage Diff @@
## master #1495 +/- ##
==========================================
- Coverage 55.14% 55.14% -0.01%
==========================================
Files 289 289
Lines 19371 19391 +20
==========================================
+ Hits 10683 10693 +10
- Misses 7997 8007 +10
Partials 691 691 |
thaJeztah
added
impact/changelog
status/1-design-review
impact/documentation
and removed
status/0-triage
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented multiple files copy functionality, described and requested under moby/moby issue no moby/moby#37961
Example:
docker cp container:file-a container:file-b localdocker cp local-file-a local-file-b container:folder- What and How I did
I've modified cp.go to handle more than 2 arguments, handled error cases as were defined before, where logic states for N number of sources and 1 destination only.
- How to verify it
Now it is possible to use docker cp as defined in example.
- Description for the changelog
docker cp support for multiple files in one command