Add example get API version #1502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please sign your commits following these rules: $ git clone -b "patch-1" git@github.com:Kilo59/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
Codecov Report
@@ Coverage Diff @@
## master #1502 +/- ##
==========================================
- Coverage 55.23% 55.14% -0.09%
==========================================
Files 289 289
Lines 19374 19371 -3
==========================================
- Hits 10702 10683 -19
- Misses 7977 7997 +20
+ Partials 695 691 -4 |
Getting the client API version is non-intuitive.
Other keys follow the json example or the version output, however `'{{.Client.ApiVersion}}'` does not work, nor does `'{{.Client.APIversion}}'`
Signed-off-by: Gabriel Gore <gabgore@cisco.com>
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Codecov Report
@@ Coverage Diff @@
## master #1502 +/- ##
=======================================
Coverage 59.47% 59.48%
=======================================
Files 285 287 +2
Lines 24179 24182 +3
=======================================
+ Hits 14381 14385 +4
Misses 8931 8931
+ Partials 867 866 -1 |
thaJeztah
approved these changes
Apr 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting the client API version is non-intuitive.
Other keys follow the json example or the version output, however
'{{.Client.ApiVersion}}'does not work, nor does'{{.Client.APIversion}}'- What I did
Added an example to the
docker versiondocs- How I did it
- How to verify it
- Description for the changelog
Added an example for getting Client API version
- A picture of a cute animal (not mandatory but encouraged)