Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some bashisms #1692

Merged
merged 1 commit into from Mar 21, 2019
Merged

Remove some bashisms #1692

merged 1 commit into from Mar 21, 2019

Conversation

thaJeztah
Copy link
Member

ping @tianon @albers PTAL 馃

@thaJeztah
Copy link
Member Author

thaJeztah commented Feb 26, 2019 •
edited

Interesting; shellcheck doesn't find these;

/go/src/github.com/docker/cli/scripts/build/windows: 6: set: Illegal option -o pipefail
/go/src/github.com/docker/cli/scripts/build/osx: 6: set: Illegal option -o pipefail

@codecov-io
Copy link

codecov-io commented Feb 26, 2019 •
edited

Codecov Report

Merging #1692 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1692      +/-   ##
==========================================
- Coverage   56.12%   56.12%   -0.01%     
==========================================
  Files         306      306              
  Lines       21030    21025       -5     
==========================================
- Hits        11803    11800       -3     
+ Misses       8373     8371       -2     
  Partials      854      854

@thaJeztah
Copy link
Member Author

hm.. one more revert needed 馃槙

[3B./scripts/test/e2e/wait-on-daemon: 2: set: Illegal option -o pipefail

@thaJeztah thaJeztah mentioned this pull request Feb 26, 2019
Merged
@thaJeztah
Copy link
Member Author

Ah; looks like we need koalaman/shellcheck#1480 if we want to really check (which is not yet in a shellcheck release)

@thaJeztah
Remove some bashisms
5aeb7a0 
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
kolyshkin
kolyshkin approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@kolyshkin kolyshkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; I'd love to have a space in between every ; and then but that is out of scope.

tianon
tianon approved these changes Mar 21, 2019
View reviewed changes
Copy link
Contributor

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoops, not sure how I missed this; sorry! LGTM too 馃憤

albers
albers approved these changes Mar 21, 2019
View reviewed changes
Copy link
Collaborator

@albers albers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiborvass tiborvass merged commit 086df60 into docker:master Mar 21, 2019
@GordonTheTurtle GordonTheTurtle added this to the 19.03.0 milestone Mar 21, 2019
@thaJeztah thaJeztah deleted the remove_bashisms branch March 21, 2019 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tianon tianon tianon approved these changes

@tiborvass tiborvass tiborvass approved these changes

@albers albers albers approved these changes

@kolyshkin kolyshkin kolyshkin approved these changes

Assignees
No one assigned
Labels
status/2-code-review
Projects
None yet
Milestone
19.03.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@thaJeztah @codecov-io @tianon @tiborvass @albers @kolyshkin @GordonTheTurtle