Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18.09 backport] Update PKCS11 library #1694

Merged
merged 1 commit into from
Feb 27, 2019

Conversation

thaJeztah
Copy link
Member

backport of #1691 for 18.09

The new version no longer links to libltdl which simplifies build
and dependencies.

See notaryproject/notary#1434

The new version no longer links to libltdl which simplifies build
and dependencies.

See notaryproject/notary#1434

Signed-off-by: Justin Cormack <justin.cormack@docker.com>
(cherry picked from commit cb3e55b)
Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah
Copy link
Member Author

ping @justincormack @andrewhsu PTAL

@codecov-io
Copy link

Codecov Report

Merging #1694 into 18.09 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            18.09    #1694   +/-   ##
=======================================
  Coverage   54.09%   54.09%           
=======================================
  Files         290      290           
  Lines       19406    19406           
=======================================
  Hits        10498    10498           
  Misses       8236     8236           
  Partials      672      672

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #1694 into 18.09 will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##            18.09    #1694   +/-   ##
=======================================
  Coverage   54.09%   54.09%           
=======================================
  Files         290      290           
  Lines       19406    19406           
=======================================
  Hits        10498    10498           
  Misses       8236     8236           
  Partials      672      672

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu andrewhsu merged commit 9352be5 into docker:18.09 Feb 27, 2019
@thaJeztah thaJeztah deleted the 18.09_backport_nolibtool branch February 27, 2019 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants