[18.09 backport] Fix the stack informer's selector used to track deployment #1794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Old selector was wrong (it watched for the label we applied to child resources when reconciling the stack, instead of the stack itself) This should be back-ported to older version of the CLI Signed-off-by: Simon Ferquel <simon.ferquel@docker.com> (cherry picked from commit 8cd74eb) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
ping @simonferquel @silvin-lubecki PTAL |
Codecov Report
@@ Coverage Diff @@
## 18.09 #1794 +/- ##
==========================================
+ Coverage 54.22% 54.23% +0.01%
==========================================
Files 290 290
Lines 19428 19428
==========================================
+ Hits 10535 10537 +2
+ Misses 8214 8212 -2
Partials 679 679 |
1 similar comment
Codecov Report
@@ Coverage Diff @@
## 18.09 #1794 +/- ##
==========================================
+ Coverage 54.22% 54.23% +0.01%
==========================================
Files 290 290
Lines 19428 19428
==========================================
+ Hits 10535 10537 +2
+ Misses 8214 8212 -2
Partials 679 679 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #1784 for 18.09
Old selector was wrong (it watched for the label we applied to child
resources when reconciling the stack, instead of the stack itself)
This should be back-ported to older version of the CLI