Regroup all kubernetes extra-fields under x-kubernetes #1823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This regroup all Kubernetes extra fields for compose-on-kubernetes v1alpha3 in a single x-kubernetes object. Also use the same naming scheme as cap_add etc. for fiels inside this object. Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
simonferquel
force-pushed
the
refactor-kubernetes-extras
branch
from
648e1a9
to
e0f20fd
Compare
Codecov Report
@@ Coverage Diff @@
## master #1823 +/- ##
==========================================
- Coverage 56.38% 56.37% -0.01%
==========================================
Files 308 308
Lines 21479 21468 -11
==========================================
- Hits 12110 12103 -7
+ Misses 8481 8479 -2
+ Partials 888 886 -2 |
|
👍 definitely a lot cleaner, and likely better maintainable @vdemeester @silvin-lubecki PTAL; I was discussing this with @simonferquel, and thought this would be a cleaner solution than adding yet-another-x-field for each thing kubernetes-specific (that isn't a "stable" API yet) |
thaJeztah
added
area/kubernetes
impact/compose-file
status/1-design-review
and removed
status/0-triage
labels
|
looks good to me, but waiting for others to have a look |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
This regroup all Kubernetes extra fields for compose-on-kubernetes v1alpha3 in a single x-kubernetes object.
Also use the same naming scheme as cap_add etc. for fields inside this object.
- How I did it
Just a little bit of refactoring
- How to verify it
This is covered by unit tests