-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix remove_test output duplication #185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Codecov Report
@@ Coverage Diff @@
## master #185 +/- ##
=========================================
Coverage ? 45.34%
=========================================
Files ? 171
Lines ? 11482
Branches ? 0
=========================================
Hits ? 5206
Misses ? 5979
Partials ? 297 |
Signed-off-by: Vincent Demeester <vincent@sbr.pm>
c80a23d
to
dd924eb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
still LGTM
full diff: mitchellh/mapstructure@v1.0.0...v1.3.2 v1.3.2 - Decode into interface type with a struct value is supported [dockerGH-187] v1.3.1 - Squash should only squash embedded structs. [dockerGH-194] v1.3.0 - Added `",omitempty"` support. This will ignore zero values in the source structure when encoding. [dockerGH-145] v1.2.3 - Fix duplicate entries in Keys list with pointer values. [dockerGH-185] v1.2.2 - Do not add unsettable (unexported) values to the unused metadata key or "remain" value. [dockerGH-150] v1.2.1 - Go modules checksum mismatch fix v1.2.0 - Added support to capture unused values in a field using the `",remain"` value in the mapstructure tag. There is an example to showcase usage. - Added `DecoderConfig` option to always squash embedded structs - `json.Number` can decode into `uint` types - Empty slices are preserved and not replaced with nil slices - Fix panic that can occur in when decoding a map into a nil slice of structs - Improved package documentation for godoc v1.1.2 - Fix error when decode hook decodes interface implementation into interface type. [dockerGH-140] v1.1.1 - Fix panic that can happen in `decodePtr` v1.1.0 - Added `StringToIPHookFunc` to convert `string` to `net.IP` and `net.IPNet` [dockerGH-133] - Support struct to struct decoding [dockerGH-137] - If source map value is nil, then destination map value is nil (instead of empty) - If source slice value is nil, then destination slice value is nil (instead of empty) - If source pointer is nil, then destination pointer is set to nil (instead of allocated zero value of type) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
full diff: mitchellh/mapstructure@v1.0.0...v1.3.2 v1.3.2 - Decode into interface type with a struct value is supported dockerGH-187 v1.3.1 - Squash should only squash embedded structs. dockerGH-194 v1.3.0 - Added `",omitempty"` support. This will ignore zero values in the source structure when encoding. dockerGH-145 v1.2.3 - Fix duplicate entries in Keys list with pointer values. dockerGH-185 v1.2.2 - Do not add unsettable (unexported) values to the unused metadata key or "remain" value. dockerGH-150 v1.2.1 - Go modules checksum mismatch fix v1.2.0 - Added support to capture unused values in a field using the `",remain"` value in the mapstructure tag. There is an example to showcase usage. - Added `DecoderConfig` option to always squash embedded structs - `json.Number` can decode into `uint` types - Empty slices are preserved and not replaced with nil slices - Fix panic that can occur in when decoding a map into a nil slice of structs - Improved package documentation for godoc v1.1.2 - Fix error when decode hook decodes interface implementation into interface type. dockerGH-140 v1.1.1 - Fix panic that can happen in `decodePtr` v1.1.0 - Added `StringToIPHookFunc` to convert `string` to `net.IP` and `net.IPNet` dockerGH-133 - Support struct to struct decoding dockerGH-137 - If source map value is nil, then destination map value is nil (instead of empty) - If source slice value is nil, then destination slice value is nil (instead of empty) - If source pointer is nil, then destination pointer is set to nil (instead of allocated zero value of type) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Vincent Demeester vincent@sbr.pm