New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for static bearer token authentication for Kubernetes #1855
base: master
Are you sure you want to change the base?
Conversation
This adds support for importing kubeconfig file using token-based authentication. The bearer is stored within the tls store because of its sensitive nature. Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
cc @alexmavr |
Codecov Report
@@ Coverage Diff @@
## master #1855 +/- ##
==========================================
+ Coverage 56.75% 56.79% +0.03%
==========================================
Files 309 309
Lines 21658 21687 +29
==========================================
+ Hits 12292 12317 +25
- Misses 8469 8471 +2
- Partials 897 899 +2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick turnaround!
I do see the context correctly generated with the following TLSMaterial and a corresponding
However, trying to deploy a stack returns the following error:
|
Signed-off-by: Simon Ferquel <simon.ferquel@docker.com>
@simonferquel This fix is very important for anyone who work with authentication token for k8s clusters. |
@thaJeztah , |
Would be great to have this |
can this be revived? |
Fix #1852
- What I did
This adds support for importing kubeconfig file using token-based
authentication.
- How I did it
The bearer token is stored within the tls store because of its sensitive
nature.
- How to verify it
Comes with unit tests