[19.03 backport] cli-plugins: add concept of experimental plugin, only enabled in experimental mode #1905
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 23, 2019 21:28
…rimental mode To test, add $(pwd)/build/plugins-linux-amd64 to "cliPluginsExtraDirs" config and run: make plugins make binary HELLO_EXPERIMENTAL=1 docker helloworld To show it enabled: HELLO_EXPERIMENTAL=1 DOCKER_CLI_EXPERIMENTAL=enabled docker helloworld Signed-off-by: Tibor Vass <tibor@docker.com> (cherry picked from commit 6ca8783) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Signed-off-by: Tibor Vass <tibor@docker.com> (cherry picked from commit bb8e89b) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
|
ping @tiborvass @andrewhsu @silvin-lubecki @tonistiigi PTAL |
Codecov Report
@@ Coverage Diff @@
## 19.03 #1905 +/- ##
==========================================
- Coverage 56.73% 56.72% -0.01%
==========================================
Files 309 309
Lines 21666 21678 +12
==========================================
+ Hits 12292 12297 +5
- Misses 8477 8483 +6
- Partials 897 898 +1 |
tiborvass
approved these changes
May 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #1898 for 19.03
closes #1897 for 19.03
To test, add $(pwd)/build/plugins-linux-amd64 to "cliPluginsExtraDirs" config and run:
To show it enabled: