Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
noticed that when checking for if the user has entered the escape sequence
after starting the container, the code was checking that the error from
inspect was a term.EscapeError rather than the error from attach in order to
mask the error returned to a nil one - I think this is the error that was
intended to be checked here.
I did not add any tests, sorry, and I'm just gonna go with the social experiment to see
if I can get away with it first ;)