Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

container start wrong error check #1914

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rdallman
Copy link

noticed that when checking for if the user has entered the escape sequence
after starting the container, the code was checking that the error from
inspect was a term.EscapeError rather than the error from attach in order to
mask the error returned to a nil one - I think this is the error that was
intended to be checked here.

I did not add any tests, sorry, and I'm just gonna go with the social experiment to see
if I can get away with it first ;)

noticed that when checking for if the user has entered the escape sequence
after starting the container, the code was checking that the error from
inspect was a term.EscapeError rather than the error from attach in order to
mask the error returned to a nil one - I think this is the error that was
intended to be checked here.

Signed-off-by: Reed Allman <reed@rdallman.com>
@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "fix-attach-err-check" git@github.com:rdallman/cli-1.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@codecov-io
Copy link

Codecov Report

Merging #1914 into master will not change coverage.
The diff coverage is 0%.

@@           Coverage Diff           @@
##           master    #1914   +/-   ##
=======================================
  Coverage   56.71%   56.71%           
=======================================
  Files         310      310           
  Lines       21792    21792           
=======================================
  Hits        12359    12359           
  Misses       8518     8518           
  Partials      915      915

@thaJeztah thaJeztah added the kind/bugfix PR's that fix bugs label Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants