Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k8s to v.1.14.3 #1937

Closed
wants to merge 4 commits into from
Closed

Conversation

silvin-lubecki
Copy link
Contributor

- What I did

Bump k8s.io/api kubernetes-1.14.0 -> kubernetes-1.14.3
Bump k8s.io/apimachinery kubernetes-1.14.0 -> kubernetes-1.14.3
Bump k8s.io/client-go kubernetes-1.14.0 -> kubernetes-1.14.3
Bump k8s.io/kubernetes v1.14.0 -> v1.14.3

- Description for the changelog

  • Bump k8s to v.1.14.3

- A picture of a cute animal (not mandatory but encouraged)
image

kubernetes-1.14.0 -> kubernetes-1.14.3

Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
kubernetes-1.14.0 -> kubernetes-1.14.3

Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
kubernetes-1.14.0 -> kubernetes-1.14.3

Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
v-1.14.0 -> v-1.14.3

Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
@codecov-io
Copy link

Codecov Report

Merging #1937 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1937   +/-   ##
=======================================
  Coverage   56.72%   56.72%           
=======================================
  Files         310      310           
  Lines       21800    21800           
=======================================
  Hits        12367    12367           
  Misses       8518     8518           
  Partials      915      915

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #1937 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1937   +/-   ##
=======================================
  Coverage   56.72%   56.72%           
=======================================
  Files         310      310           
  Lines       21800    21800           
=======================================
  Hits        12367    12367           
  Misses       8518     8518           
  Partials      915      915

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah
Copy link
Member

ping @tiborvass @justincormack @kolyshkin PTAL

k8s.io/klog 71442cd4037d612096940ceb0f3fec3f7fff66e0 # v0.2.0
k8s.io/kube-openapi 5e45bb682580c9be5ffa4d27d367f0eeba125c7b
k8s.io/kubernetes 641856db18352033a0d96dbc99153fa3b27298e5 # v1.14.0
k8s.io/kubernetes 5e53fd6bc17c0dec8434817e69b04a25d8ae0ff0 # v1.14.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually; looks like this version doesn't match with the version that compose-on-kubernetes is developed against / tested with; https://github.com/docker/cli/pull/1937/files#diff-4061fcef378a6d912e14e2ce162a1995R16

I see the last tagged version of compose-on-kubernetes uses kubernetes 1.14.7 (so is one patch release behind on the latest 1.14.x); I can open a PR upstream to update it to 1.14.8, and once that's tagged we could update venturing for both kubernetes and compose-on-kubernetes

@thaJeztah
Copy link
Member

closing as this was obsoleted by #2140

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants