fix: add dockerignore read check. #1939
Conversation
Signed-off-by: Jintao Zhang <zhangjintao9020@gmail.com>
| @@ -37,3 +37,17 @@ func TrimBuildFilesFromExcludes(excludes []string, dockerfile string, dockerfile | |||
| } | |||
| return excludes | |||
| } | |||
|
|
|||
| // OpenDockerignore try to open the .dockerignore file in the context directory | |||
| func OpenDockerignore(contextDir string) error { | |||
There was a problem hiding this comment.
Maybe this function should be changed to a clearer name.
Codecov Report
@@ Coverage Diff @@
## master #1939 +/- ##
=========================================
- Coverage 56.72% 56.7% -0.03%
=========================================
Files 310 310
Lines 21800 21811 +11
=========================================
Hits 12367 12367
- Misses 8518 8529 +11
Partials 915 915 |
| @@ -103,6 +103,11 @@ func runBuildBuildKit(dockerCli command.Cli, options buildOptions) error { | |||
| } else { | |||
| dockerfileDir = options.context | |||
| } | |||
|
|
|||
| if err := build.OpenDockerignore(contextDir); err != nil { | |||
There was a problem hiding this comment.
When using buildkit, a session is opened; wondering if an error should be produced on any file that is attempted to send to the daemon (instead of checking for specific files).
@tonistiigi wdyt?
|
ping @tiborvass @AkihiroSuda ptal #1939 (comment) |
|
@tao12345666333 thanks for the contribution. I'm continuing the discussion of the issue on #1938 (comment). We do want buildkit to be as close as possible/sensible to non-buildkit builds. If the bug is accepted, I believe the correct way would be to simply stat-ing |
Signed-off-by: Jintao Zhang zhangjintao9020@gmail.com
- What I did
fix #1938
- How I did it
add
OpenDockerignorefunction.- How to verify it
- Description for the changelog
fix: add dockerignore read check.
- A picture of a cute animal (not mandatory but encouraged)