Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snap #2019

Closed
wants to merge 1 commit into from
Closed

snap #2019

wants to merge 1 commit into from

Conversation

mikeroyal
Copy link

Includes a snapcraft.yaml to build snap.

- What I did
Created a snap package for Docker CLI.

- How I did it
Added snapcraft.yaml to build snap.

- How to verify it
Prep:
sudo snap install snapcraft --classic
sudo snap install multipass --beta --classic

- Description for the changelog

A snap package for Docker CLI.

- A picture of a cute animal (not mandatory but encouraged)
pug

Includes a snapcraft.yaml to build [snap](https://snapcraft.io/).
@GordonTheTurtle
Copy link

Please sign your commits following these rules:
https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work
The easiest way to do this is to amend the last commit:

$ git clone -b "snap" git@github.com:mikeroyal/cli.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

@thaJeztah
Copy link
Member

@mikeroyal Thanks for your contribution; could you sign-off your commit (our bot provided some instructions on how to do so, but feel free to ask if you need more information).

Some questions/remarks about the contribution itself;

  • Is the intent of this file to publish packages on https://snapcraft.io, or to add a file as an example for users to build a snap package themselves?
  • if the latter (to allow users to build it themselves);
    • Is it a requirement for this file to be in a snap directory at the top?
    • If not, then I'd prefer the snap directory to be moved inside the contrib/ directory
  • if the former; Docker currently has no plan to support snap builds, or to have those published on https://snapcraft.io, in which case I don't think I'd be able to accept this contribution, as it would confuse people into thinking those packages are officially supported.

Thanks in advance!

@mikeroyal
Copy link
Author

Okay, I understand I will close this PR

@mikeroyal mikeroyal closed this Oct 29, 2019
@thaJeztah
Copy link
Member

thaJeztah commented Oct 29, 2019

Thank you! And sorry your contribution wasn't merged 🤗

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants