Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2030 fixed link when bridge stated #2046

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

pcellix
Copy link

@pcellix pcellix commented Aug 14, 2019

fixes 2030 issue

added additional check if it is not default network named 'bridge'
If it is then links can be passed

Can be checked by running:
docker run --network=bridge --link containera:aliasa busybox

Signed-off-by: Wojciech Kosowicz pcellix@gmail.com

Signed-off-by: Wojciech Kosowicz <pcellix@gmail.com>
@codecov-io
Copy link

Codecov Report

Merging #2046 into master will increase coverage by <.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #2046      +/-   ##
==========================================
+ Coverage   56.79%   56.79%   +<.01%     
==========================================
  Files         311      311              
  Lines       21836    21837       +1     
==========================================
+ Hits        12402    12403       +1     
  Misses       8519     8519              
  Partials      915      915

1 similar comment
@codecov-io
Copy link

Codecov Report

Merging #2046 into master will increase coverage by <.01%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master    #2046      +/-   ##
==========================================
+ Coverage   56.79%   56.79%   +<.01%     
==========================================
  Files         311      311              
  Lines       21836    21837       +1     
==========================================
+ Hits        12402    12403       +1     
  Misses       8519     8519              
  Partials      915      915

@pcellix
Copy link
Author

pcellix commented Aug 15, 2019

Hi can anybody can tell me what's the problem with codecov and how to have it passed?
This is my 1st PR here :)
Thank you!

@pcellix
Copy link
Author

pcellix commented Oct 10, 2019

Hello
Any feedback so this one can be closed?

@pcellix
Copy link
Author

pcellix commented Dec 16, 2019

Hi

Please let know how to continue with it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants