Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker info: list CLI plugins alphabetically #2236

Merged
merged 1 commit into from
Jan 6, 2020

Conversation

thaJeztah
Copy link
Member

Before this change, plugins were listed in a random order:

Client:
 Debug Mode: false
 Plugins:
  doodle: Docker Doodles  all around! 🐳 🎃 (thaJeztah, v0.0.1)
  shell: Open a browser shell on the Docker Host. (thaJeztah, v0.0.1)
  app: Docker Application (Docker Inc., v0.8.0)
  buildx: Build with BuildKit (Docker Inc., v0.3.1-tp-docker)

With this change, plugins are listed alphabetically:

Client:
 Debug Mode: false
 Plugins:
  app: Docker Application (Docker Inc., v0.8.0)
  buildx: Build with BuildKit (Docker Inc., v0.3.1-tp-docker)
  doodle: Docker Doodles  all around! 🐳 🎃 (thaJeztah, v0.0.1)
  shell: Open a browser shell on the Docker Host. (thaJeztah, v0.0.1)

- What I did

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

Before this change, plugins were listed in a random order:

    Client:
     Debug Mode: false
     Plugins:
      doodle: Docker Doodles  all around! 🐳 🎃 (thaJeztah, v0.0.1)
      shell: Open a browser shell on the Docker Host. (thaJeztah, v0.0.1)
      app: Docker Application (Docker Inc., v0.8.0)
      buildx: Build with BuildKit (Docker Inc., v0.3.1-tp-docker)

With this change, plugins are listed alphabetically:

    Client:
     Debug Mode: false
     Plugins:
      app: Docker Application (Docker Inc., v0.8.0)
      buildx: Build with BuildKit (Docker Inc., v0.3.1-tp-docker)
      doodle: Docker Doodles  all around! 🐳 🎃 (thaJeztah, v0.0.1)
      shell: Open a browser shell on the Docker Host. (thaJeztah, v0.0.1)

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@FernandoMiguel
Copy link

oh wait, I'm not a contributor to this repo ahah

@thaJeztah
Copy link
Member Author

reviewing is open to everyone! more eyes never hurt, right? 👌🤗

@FernandoMiguel
Copy link

@thaJeztah for sure.
but i'm a collaborator on buildkit and buildx repo... and the ticket from there linked to this PR....
I reviewed and approved, before realising here won't make much difference on the workflow :)

@thaJeztah
Copy link
Member Author

ping @silvin-lubecki @vdemeester PTAL 🤗

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐯

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit f7f4a19 into docker:master Jan 6, 2020
@thaJeztah thaJeztah deleted the plugin_sorting branch January 6, 2020 15:33
@thaJeztah thaJeztah added this to the next milestone Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants