Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
Incrementally sending build context #231
Adds support for incremental context updates to
I also noticed that it vendors in chrootarchive and reexec package. These are not really needed but require some refactoring. Either splitting the receiver and sender part to a separate package, or passing an archiver instance into the transfer function. I can do that in a follow-up with next update.
@@ Coverage Diff @@ ## master #231 +/- ## ========================================== - Coverage 47.19% 46.58% -0.62% ========================================== Files 171 172 +1 Lines 11556 11631 +75 ========================================== - Hits 5454 5418 -36 - Misses 5791 5902 +111 Partials 311 311
Some tests would be great.
We don't have any in master yet, but I wrote on in #233 which uses a fakeClient. You could grab my changes to the fake from that PR.
Splitting out some functions might make it possible to test some in isolation as well (like the build shared key functionality).