Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: make sure environment vars are reset after tests #2426

Merged
merged 1 commit into from Apr 9, 2020

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Apr 9, 2020

The trust tests were not resetting the environment after they ran, which could result in tests following those tests to fail.

While at it, I also updated some other tests to use gotest.tools

@thaJeztah
Copy link
Member Author

@silvin-lubecki PTAL

The trust tests were not resetting the environment after they
ran, which could result in tests following those tests to fail.

While at it, I also updated some other tests to use gotest.tools

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@silvin-lubecki silvin-lubecki merged commit ad256ba into docker:master Apr 9, 2020
@thaJeztah thaJeztah deleted the fix_test_env branch April 9, 2020 16:05
@thaJeztah thaJeztah added this to the 20.03.0 milestone Apr 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants