Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bash completion for service create|update --entrypoint #247

Merged
merged 1 commit into from Jun 30, 2017

Conversation

albers
Copy link
Collaborator

@albers albers commented Jun 27, 2017

This adds bash completion for moby/moby#29228.
Also fixes a wrong option: service update --arg should be --args.

ping @sdurrheimer for zsh completion

Also fixes a wrong option: `--arg` should be `--args`.

Signed-off-by: Harald Albers <github@albersweb.de>
@codecov-io
Copy link

codecov-io commented Jun 27, 2017

Codecov Report

Merging #247 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #247   +/-   ##
=======================================
  Coverage   46.85%   46.85%           
=======================================
  Files         172      172           
  Lines       11692    11692           
=======================================
  Hits         5478     5478           
  Misses       5902     5902           
  Partials      312      312

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐮

@thaJeztah thaJeztah added this to the 17.06.1 milestone Jun 30, 2017
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 1c4d070 into docker:master Jun 30, 2017
@albers albers deleted the completion-service--entrypoint branch June 30, 2017 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants