Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
progress: Show task error in place of progress bar #259
If a task encounters an error, the interactive "service create" and "service update" commands should show that error instead of showing a stuck progress bar.
How can we test these changes?
Full integration tests of the progress bars is going to be difficult, but we should be able to unit test a bunch of the internal logic.
I am going to work on some tests for the internal logic. Any preferences on adding them to this PR or a separate one?
@@ Coverage Diff @@ ## master #259 +/- ## ========================================= - Coverage 48.68% 46.9% -1.79% ========================================= Files 185 173 -12 Lines 12168 11942 -226 ========================================= - Hits 5924 5601 -323 - Misses 5877 6019 +142 + Partials 367 322 -45