Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bash completion typo docker manifest rm #2728

Merged
merged 1 commit into from Sep 17, 2020
Merged

Fix bash completion typo docker manifest rm #2728

merged 1 commit into from Sep 17, 2020

Conversation

jennydaman
Copy link
Contributor

Originally posted by @albers in #2449 (comment)

@jennydaman
Fix typo
bd89487 
Signed-off-by: Jennings Zhang <jenni_zh@protonmail.com>
@jennydaman jennydaman mentioned this pull request Sep 17, 2020
Merged
albers
albers approved these changes Sep 17, 2020
View reviewed changes
Copy link
Collaborator

@albers albers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much. ❤️ LGTM

@codecov-commenter
Copy link

Codecov Report

Merging #2728 into master will decrease coverage by 1.46%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2728      +/-   ##
==========================================
- Coverage   58.61%   57.15%   -1.47%     
==========================================
  Files         297      297              
  Lines       21387    18657    -2730     
==========================================
- Hits        12537    10663    -1874     
+ Misses       7935     7132     -803     
+ Partials      915      862      -53

thaJeztah
thaJeztah approved these changes Sep 17, 2020
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@thaJeztah thaJeztah merged commit 75598aa into docker:master Sep 17, 2020
@thaJeztah thaJeztah added this to the 20.03.0 milestone Sep 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

@albers albers albers approved these changes

Assignees
No one assigned
Labels
area/completion
Projects
None yet
Milestone
20.10.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jennydaman @codecov-commenter @thaJeztah @albers