Bump moby to 87df0e533b619c088091fd1e2310e92bb9a24822

[thaJeztah]

Includes changes from;

• Add a LastTagTime for images (Add a LastTagTime for images moby/moby#31497)
• Fix handling of remote "git@" notation (Fix handling of remote "git@" notation moby/moby#33696)
• Move some api package functions away (Move some api package functions away moby/moby#33798) (related to Import DisplayablePorts from moby/moby source #236)
• Set ping version even on error (Set ping version even on error moby/moby#33827)
• Do not add duplicate platform information to service spec (Do not add duplicate platform information to service spec moby/moby#33867)
• Refactor MountPoint Setup function in volume.go (Refactor MountPoint Setup function in volume.go moby/moby#33890)

[thaJeztah]

Looks like a test needs updating, or we need to change upstream to omit the Metadata.LastTagTime if not set;

--- FAIL: TestNewInspectCommandSuccess (0.00s)
Error Trace:	helpers.go:23
		inspect_test.go:89
Error:      	Not equal: 
expected: "[{\"Id\":\"\",\"RepoTags\":null,\"RepoDigests\":null,\"Parent\":\"\",\"Comment\":\"\",\"Created\":\"\",\"Container\":\"\",\"ContainerConfig\":null,\"DockerVersion\":\"\",\"Author\":\"\",\"Config\":null,\"Architecture\":\"\",\"Os\":\"\",\"Size\":0,\"VirtualSize\":0,\"GraphDriver\":{\"Data\":null,\"Name\":\"\"},\"RootFS\":{\"Type\":\"\"}}]"
received: "[{\"Id\":\"\",\"RepoTags\":null,\"RepoDigests\":null,\"Parent\":\"\",\"Comment\":\"\",\"Created\":\"\",\"Container\":\"\",\"ContainerConfig\":null,\"DockerVersion\":\"\",\"Author\":\"\",\"Config\":null,\"Architecture\":\"\",\"Os\":\"\",\"Size\":0,\"VirtualSize\":0,\"GraphDriver\":{\"Data\":null,\"Name\":\"\"},\"RootFS\":{\"Type\":\"\"},\"Metadata\":{\"LastTagTime\":\"0001-01-01T00:00:00Z\"}}]"

@dnephin wdyt?

[thaJeztah]

Actually, I wonder if we should change the way we test; quoting from the API reference;

The API uses an open schema model, which means server may add extra properties to responses. Likewise, the server will ignore any extra query parameters and request body properties. When you write clients, you need to ignore additional properties in responses to ensure they do not break when talking to newer Docker daemons.

[dnephin]

I think we just need to update the test to match the new expected result

[codecov-io]

Codecov Report

Merging #286 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #286      +/-   ##
==========================================
- Coverage   48.93%   48.92%   -0.01%     
==========================================
  Files         177      177              
  Lines       11846    11846              
==========================================
- Hits         5797     5796       -1     
- Misses       5687     5688       +1     
  Partials      362      362

[thaJeztah]

@dnephin @vdemeester updated the test PTAL

[vdemeester]

LGTM 🐸

[cpuguy83]

LGTM