New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Fix wrong bridge driver option #2984
Conversation
Signed-off-by: OKA Naoya <git@okanaoya.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
@@ -175,7 +175,7 @@ equivalent docker daemon flags used for docker0 bridge: | |||
| `com.docker.network.bridge.enable_icc` | `--icc` | Enable or Disable Inter Container Connectivity | | |||
| `com.docker.network.bridge.host_binding_ipv4` | `--ip` | Default IP when binding container ports | | |||
| `com.docker.network.driver.mtu` | `--mtu` | Set the containers network MTU | | |||
| `com.docker.network.container_interface_prefix` | - | Set a custom prefix for container interfaces | | |||
| `com.docker.network.container_iface_prefix` | - | Set a custom prefix for container interfaces | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm.. good catch; looks indeed the correct name; https://github.com/moby/moby/blob/a8a769f04f7ae44117772943ef0f4607b54e05ff/vendor/github.com/docker/libnetwork/netlabel/labels.go#L54-L55
// ContainerIfacePrefix can be used to override the interface prefix used inside the container
ContainerIfacePrefix = Prefix + ".container_iface_prefix"
Looks like moby/moby#31811 updated the changelog incorrectly, probably because the title of the libnetwork pull request had the wrong name in it (I just fixed that); moby/libnetwork#1667
opened moby/moby#42446 and docker/docs#12921 to fix the changelog entry |
- What I did
Fixed a wrong bridge driver option for
docker network create
.- How I did it
Fixed documentation.
- How to verify it
With the option in current documentation, the name of the interface in a container remains unchanged (eth0).
With
com.docker.network.container_iface_prefix
, it works perfectly.- Description for the changelog
N/A
- A picture of a cute animal (not mandatory but encouraged)
This is Pui Pui Molcar, a stop-motion anime featuring Molmots, booming in Japan. (@molcar_anime)